LITE-28560: Adding task to check and update product on commerce #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hairash
approved these changes
Sep 18, 2023
| return True | ||
|
|
||
|
|
||
| def apply_ppr_and_delegate_to_marketplaces(deployment_request): | ||
| def check_and_update_product(deployment_request, cbc_service, **kwargs): | ||
| if not deployment_request.manually: |
There was a problem hiding this comment.
[COD-C] Might be more convenient to write:
if deployment_request.manually:
return True
to avoid this indent. What do you think?
There was a problem hiding this comment.
I did it in this way to not duplicate the return True at the end of the function. But don't mind change it
akodelia
force-pushed
the
feature/LITE-28560-Update-Product
branch
from
cec3dc5
to
d6c3123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.